具有数据结构的 PHP 类定义


PHP Class Definition with Data Structure

我想做的是以下...将 CLASS FILE 包含在我的其他类之一中,然后执行以下操作:

    $zSubscription = new zSubscription();
    $zSubscription->Account->AccountNumber = "ABCD-230948";
    $zSubscription->BillToContact->Address1= "123 Dirt Lane Road";
    $this->createContact($zSubscription);

public function createContact($subscriptionObj){
    if (strlen($subscriptionObj->Account->AccountNumber) > 10){
        // Do something special
        echo "Batch Processing<br />";
        if ($subscriptionObj->Account->Batch == "Batch1"){
            echo "Running Batch 1";
        }
    }
}

应设置 BATCH1(这是预期结果)当前未设置。

要通过require_once包含的类文件如下:

/**
* Zuora Definition Class
* @author Will H
* @license MIT
*/
class Account{
    /** @var string */
    public $AccountNumber  = null;
    /** @var bool */
    public $AllowInvoiceEdit   = true;
    /** @var bool */
    public $AutoPay = true;
    /** @var string */
    public $Batch    = "Batch1";
    /** @var string */
    public $BcdSettingOption    = "ManualSet";
    /** @var int */
    public $BillCycleDay     = 31;
    /** @var string */
    public $CrmId;
    /** @var string */
    public $Currency = "USD";
    /** @var string */
    public $CustomerServiceRepName = "Online Order";
    /** @var string */
    public $Name;
    /** @var string */
    public $PaymentTerm = "Due Upon Receipt";
    /** @var string */
    public $PurchaseOrderNumber = null;
    /** @var string */
    public $SalesRepName = "Online Order";
}
class PaymentMethod{ 
    /** @var string */
    public $CreditCardAddress1;
    /** @var string */
    public $CreditCardAddress2;
    /** @var string */
    public $CreditCardCity;
    /** @var string */
    public $CreditCardCountry;
    /** @var int */
    public $CreditCardExpirationMonth;
    /** @var int */
    public $CreditCardExpirationYear;
    /** @var string */
    public $CreditCardHolderName;
    /** @var string */
    public $CreditCardNumber;
    /** @var string */
    public $CreditCardPostalCode;
    /** @var string */
    public $CreditCardState;
    /** @var string */
    public $CreditCardType;
    /** @var string */
    public $Type = 'CreditCard';
}
class BillToContact{
    /** @var string */
    public $Address1;
    /** @var string */
    public $Address2;
    /** @var string */
    public $City;
    /** @var string */
    public $Country;
    /** @var string */
    public $FirstName;
    /** @var string */
    public $LastName;
    /** @var string */
    public $PostalCode;
    /** @var string */
    public $State;
    /** @var string */
    public $WorkEmail;
    /** @var string */
    public $WorkPhone;
}
class SubscribeOptions{
    /** @var bool */
    public $GenerateInvoice = true;
    /** @var bool */
    public $ProcessPayments = true;
}
class Subscription{
    /** @var bool */
    public $AutoRenew = true;
    /** @var string */
    public $ContractAcceptanceDate;
    /** @var string */
    public $ContractEffectiveDate;
    /** @var int */
    public $InitialTerm = 12;
    /** @var int */
    public $RenewalTerm = 12;
    /** @var string */
    public $ServiceActivationDate;
    /** @var string */
    public $TermStartDate;
}
class RatePlan{
    /** @var string */
    public $ProductRatePlanId;
}
class RatePlanData{
    /** @var RatePlan */
    public $RatePlan;
}
class SubscriptionData{
    /** @var Subscription */
    public $Subscription;
    /** @var RatePlanData */
    public $RatePlanData;
}
class zSubscription{
    /** @var Account */
    public $Account;
    /** @var PaymentMethod */
    public $PaymentMethod;
    /** @var BillToContact */
    public $BillToContact;
    /** @var SubscribeOptions */
    public $SubscribeOptions;
    /** @var SubscriptionData */
    public $SubscriptionData;
}
?>

说你的代码泄漏了封装,是轻描淡写的。根本没有封装。你可以用数组替换你的"对象",然后把它称为一天。

在一个写得很好的类中,你只有privateprotected变量。它们只能通过 GettersSetters 获得,即便如此,您也必须小心翼翼地使用它。你应该阅读这篇文章:Martin Fowler的"GetterEradicator"。

代码中的另一个问题是您似乎在构造函数中做了一些巫毒教。看看这个例子:

$zSubscription = new zSubscription();
$zSubscription->Account->AccountNumber = "ABCD-230948";
$zSubscription->BillToContact->Address1= "123 Dirt Lane Road";

AccountBillToContact从何而来?您将对象(在zSubscription::__construct()方法中创建,从而导致与两个类的名称紧密耦合)暴露给完全不相关的上下文。这是违反得墨忒耳定律,导致抽象泄漏。