这是一个更简洁的控制器方法


A cleaner way to go with my controller method

我正在制作一个应用程序,将一个单词从一种语言翻译成英语,并获取有关它的信息(例如定义,在句子中的使用,同义词,声音表示)

我的函数的作用:

  1. 在数据库中搜索翻译。如果找到,我们返回它。
  2. 如果没有找到,我们翻译一个词使用谷歌翻译,或Yandex翻译API。
  3. 如果找到翻译,我们下载它的声音表示,将翻译保存到数据库,并添加其他API的附加信息
  4. 我们返回一个json响应,其中包含所有信息。

现在我的controllers方法非常大,我找不到更简洁的方法了

任何帮助都是感激的。

public function store(Request $request)
{
    $translated = $request->get('translated');
    $translation = $this->translation->findBy('translated', $translated)->first();
    if ($translation) {
        return Response::json(['translation' => $this->translation->with(['examples', 'definitions', 'synonyms', 'images'])->find($translation->id)], ResponseCode::HTTP_CREATED);
    }
    $data = $request->all();
    $data['translation'] = $this->translate($translated);
    if ($translated == $data['translation']) {
        Log::info('Translation not found: ' . $data['translation']);
        return $this->translationNotFound();
    }
    $downloader = new Downloader(new GoogleSpeechDownloader());
    $filename = $downloader->download($data['translation']);
    if ($filename) $data['sound_name'] = $filename;
    $translation = $this->translation->create($data);
    $this->createDefinition($translation);
    $this->createExample($translation);
    $this->createSynonym($translation);
    return Response::json(['translation' => $this->translation->with(['examples', 'definitions', 'synonyms', 'images'])->find($translation->id)], ResponseCode::HTTP_CREATED);
}
private function translationNotFound()
{
    return Response::json(['error' => 'Vertimas nerastas.'], ResponseCode::HTTP_NOT_FOUND);
}
private function createDefinition($translation)
{
    $definition = new Definition();
    $definer = new Definer(new DictionaryApiDefiner());
    try {
        $definition->definition = $definer->getDefinition($translation->translation);
        $definition->approved = true;
        $translation->definitions()->save($definition);
    } catch ('Exception $e) {
        Log::alert('Definition for word ' . $translation->translation . ' not found.');
    }
}
private function createExample($translation)
{
    $example = new Example();
    $exampler = new ExampleCreator(new YourDictionaryGouteParserExampler());
    try {
        $example->example = $exampler->getExample($translation->translation);
        $example->approved = true;
        $translation->examples()->save($example);
    } catch ('Exception $e) {
        Log::alert('Example for word ' . $translation->translation . ' not found.');
    }
}
private function createSynonym($translation)
{
    $creator = new SynonymCreator(new BigHugeLabsSynonymCreator());
    foreach ($creator->getSynonyms($translation->translation) as $s) {
        $synonym = new Synonym();
        $synonym->synonym = $s;
        $synonym->approved = true;
        $translation->synonyms()->save($synonym);
    }
}
private function translate($translated)
{
    $translator = new Translator(new GoogleTranslator());
    try {
        return $translator->translate($translated);
    } catch ('Exception $e) {
        Log::critical($e->getMessage());
    }
    $translator = new Translator(new YandexTranslator());
    return $translator->translate($translated);
}

如果您想要更干净的代码,只需为此工作创建一个类。这两个API的两个类在控制器中检查单词,如果数据库中不存在,检查其他两个API,只需将每个动作拆分为新两个类中的方法