使用可选值更新PDO


PDO update with optional values

我试图建立一个查询字符串更新一些用户信息。我的问题是password是可选的(他们更新一些东西,但不是他们的密码),client是可选的,phone是可选的。

我是这样开始的

<?php
$sql = "UPDATE users SET username = :username, name = :name, email = :email ";
if (isset($request->password)) $sql .= ',password = :password';
if (isset($request->client)) $sql .= ',client = :client';
if (isset($request->phone)) $sql .= ',phone = :phone'
$q = $db->prepare($sql);
try
{
    $q->execute(array(
        "username"      => $request->username,
        "password"      => (isset($request->password)) ? md5($request->password) : '', //--not working yet, I know
        "name"          => $request->name,
        "client"        => (isset($request->client)) ? $request->client : '',
        "email"         => $request->email,
        "phone"         => (isset($request->phone)) ? $request->phone : ''
    ));
.....
?>

我认为必须有一个更好的方法来做到这一点与PDO。此外,我还没有将WHERE id = :idOfTheUserIamEditing

合并到查询中

你的代码看起来很好,没有那么多其他的方法来完成你想要达到的目标。我建议的一件事是在检查可选字段时构建参数数组,这可以节省你做"大量的if语句":

$sql = "UPDATE users SET username = :username, name = :name, email = :email ";
$params = array();
//mandatory
$params[':username'] = $request->username;
$params[':name'] = $request->name;
$params[':email'] = $request->email;
//optional
if (isset($request->password)){
    $sql .= ',password = :password';
    $params[':password'] = $request->password;
}
if (isset($request->client)){
    $sql .= ',client = :client';
    $params[':client'] = $request->client;
}
if (isset($request->phone)){
    $sql .= ',phone = :phone';
    $params[':phone'] = $request->phone;
} 

try
{
    $q = $db->prepare($sql);
    $q->execute(array($params);
    ...