嵌套的foreach循环-任何更高效的循环 - Nested foreach loops - anything more efficient?

所以我有嵌套的foreach循环，我想知道是否有一种更有效的方法可以做到这一点，代码方面：

foreach ($arraykey as $columnname => $value) {
    foreach ($records as $field_entity_id) {    
        $fieldinsertloop = "('registration', 'reg_type', 0,".$field_entity_id.",".$field_entity_id.", 'und', 0,'".$value."','".$value."')";
    }
    $sql = "INSERT INTO " .str_replace("multi_reg", "field_data", $columnname);
    $sql .= " (entity_type, bundle, deleted, revision_id, entity_id, language, delta, ".str_replace("multi_reg_", "", $columnname)."_value, ".str_replace("multi_reg_", "", $columnname)."_format)";
    $sql .= " VALUES ";
    $sql .= $fieldinsertloop;
    db_query($sql);
}

基本上，我想优化速度，然后减少编写的代码——按照这个顺序，或者两者都优化。

您可以通过引用使用以下值来从循环中挤出更多性能：

foreach ($arraykey as $columnname => &$value) {

因此产生了&$value，但要注意，此后每次对$value进行操作时，都会影响原始的$arraykey[$columnname]值。此外，也不能确定前臂是否正确嵌套。我会向下移动嵌套foreach的结束括号：

// $value passed by reference
foreach ($arraykey as $columnname => &$value) {
    // Pass $field_entity_id by reference
    foreach ($records as &$field_entity_id) {
        $fieldinsertloop = "('registration', 'reg_type', 0,".$field_entity_id.",".$field_entity_id.", 'und', 0,'".$value."','".$value."')";
        $sql = "INSERT INTO " .str_replace("multi_reg", "field_data", $columnname);
        $sql .= " (entity_type, bundle, deleted, revision_id, entity_id, language, delta, ".str_replace("multi_reg_", "", $columnname)."_value, ".str_replace("multi_reg_", "", $columnname)."_format)";
        $sql .= " VALUES ";
        $sql .= $fieldinsertloop;
        db_query($sql);
    } // End of nested foreach moved here
}

代码的另一个问题是，您使用的是Drupal db_query()，它有一种更好的插入值的方法。如果你是，你可以将你的代码更改为：

foreach ($arraykey as $columnname => &$value) {
    $table = str_replace("multi_reg", "field_data", $columnname);
    $columns = array('entity_type', 'bundle', 'deleted', 'revision_id', 'entity_id', 'language', 'delta', str_replace("multi_reg_", "", $columnname).'_value', str_replace("multi_reg_", "", $columnname).'_format');
    foreach ($records as &$field_entity_id) {
        $values = array('registration', 'reg_type', 0, $field_entity_id, $field_entity_id, 'und', 0, $value, $value);
        //Build Associative Array for Insert
        for( $x = 0, $max = count($values); $x < $max; $x++ ) {
            $sqlValues[$columns[$x]] = $values[$x];
        }
        db_insert($table)->fields($columns)->values($sqlValues)->execute();
    }
}

或

foreach ($arraykey as $columnname => &$value) {
    $table = str_replace("multi_reg", "field_data", $columnname);
    $columns = array('entity_type', 'bundle', 'deleted', 'revision_id', 'entity_id', 'language', 'delta', str_replace("multi_reg_", "", $columnname).'_value', str_replace("multi_reg_", "", $columnname).'_format');
    $query = db_insert($table)->fields($columns);
    foreach ($records as &$field_entity_id) {
        $values = array('registration', 'reg_type', 0, $field_entity_id, $field_entity_id, 'und', 0, $value, $value);
        //Build Associative Array for Insert
        for( $x = 0, $max = count($values); $x < $max; $x++ ) {
            $sqlValues[$columns[$x]] = $values[$x];
        }
        $query->values($sqlValues);
    }
    $query->execute();
}

第二个例子应该更快，但是有更多的行。它会等待，直到所有值都添加完毕后再执行。使用db_insert()要求值在关联数组中，列名作为键。

清洁怎么样？