我正在制作一个用户配置文件更新php文件,我想知道,有没有其他方法可以简化这个检查输入是否为空的if
语句代码?当前代码如下所示:
'
<?php
session_start();
$name = test_input($_POST['name']);
$surname = test_input($_POST['surname']);
$password = $_POST['password'];
$newPassword = $_POST['newPassword'];
$newConfirmPassword = $_POST['newConfirmPassword'];
function test_input($data) {
$data = trim($data);
$data = stripslashes($data);
$data = htmlspecialchars($data);
$data = strtolower($data);
return $data;
};
if($password != $_SESSION['password']){
die('Wrong password, try again!');
}else{
if(empty($name) && empty($surname) && empty($newPassword) && empty($newConfirmPassword)){
die('No changes has been made!');
}else if(!empty($name) && empty($surname) && empty($newPassword) && empty($newConfirmPassword)){
//name update
}else if(!empty($name) && !empty($surname) && empty($newPassword) && empty($newConfirmPassword)){
//name and surname update
}else if(!empty($name) && !empty($surname) && !empty($newPassword) && empty($newConfirmPassword)){
die('New passwords do not match');
}else if(!empty($name) && !empty($surname) && empty($newPassword) && !empty($newConfirmPassword)){
die('New password do not match');
}else if(!empty($name) && empty($surname) && !empty($newPassword) && !empty($newConfirmPassword)){
//name and passwords update
}else if(!empty($name) && !empty($surname) && !empty($newPassword) && !empty($newConfirmPassword)){
//name , password and surname update
}else if(empty($name) && !empty($surname) && empty($newPassword) && empty($newConfirmPassword)){
//surname update
}else if(empty($name) && !empty($surname) && !empty($newPassword) && empty($newConfirmPassword)){
die('New passwords do not match');
}else if(empty($name) && !empty($surname) && empty($newPassword) && !empty($newConfirmPassword)){
die('New passwords do not match');
}else if(empty($name) && !empty($surname) && !empty($newPassword) && !empty($newConfirmPassword)){
//surname and password change
}else if(empty($name) && empty($surname) && !empty($newPassword) && empty($newConfirmPassword)){
die('New passwords do not match');
}else if(empty($name) && empty($surname) && empty($newPassword) && !empty($newConfirmPassword)){
die('New passwords do not match');
}else if(empty($name) && empty($surname) && !empty($newPassword) && !empty($newConfirmPassword)){
//password change
};
};
?>
'
也许有一种方法可以通过某种方式使用功能来做到这一点?
session_start();
if($_POST['password'] !== $_SESSION['password']){
die('Wrong password, try again!');
}
$data['name'] = test_input($_POST['name']);
$data['surname'] = test_input($_POST['surname']);
$passwordConfirmed = $_POST['newConfirmPassword'] === $_POST['newPassword'] && !empty($_POST['newPassword']);
$newPassword = $_POST['newPassword'];
$data = array_filter($data);
if (count($data)===0) {
die('No changes has been made!');
}
if (!empty($newPassword) && $passwordConfirmed) {
//Update password
} else {
foreach ($data as $field => $value) {
//Update field. This would work best if your $field variable makes updating easy to code.
//break; //If you only want to update one field on each request
}
}
这看起来稍微小一点。
你可以写一个可以更新的函数 a) 名称 b)姓氏 c) 密码。之后,您可以执行以下操作:
if(!empty($name)){
updateName($name);
}
if(!empty($surname)){
updateSurname($surname);
}
if(!empty($newPassword) && !empty($newConfirmPassword)){
if($newPassword == $newConfirmPassword){
updatePassword($newPassword);
}
}
我会使用多个功能:一个用于查看是否根本没有进行任何更改,一个用于测试密码是否有效等。
示例代码:
function stripName($data) {
return strtolower(htmlspecialchars(stripslashes(trim($data)));
}
function noChanges($name, $surname, $newPassword, $newConfirmPassword) {
if(empty($name) &&
empty($surname) &&
empty($newPassword) &&
empty($newConfirmPassword)
) {
return 'No changes has been made!';
}
return false;
}
function oldPasswordIsInvalid($password) {
if($password !== $_SESSION['password']){
return 'Wrong password, try again!';
}
return false;
}
function newPasswordIsInvalid($password1, $password2) {
if(empty($password1) {
return 'Password must not be empty';
}
if(empty($password2) {
return 'Password confirmation must not be empty';
}
if($password1 !== $password2) {
return 'Passwords do not match';
}
return false;
}
function errorFound(
$name,
$surname,
$password,
$newPassword,
$newConfirmPassword
) {
return
oldPasswordIsInvalid($password) ||
noChanges($name, $surname, $newPassword, $newConfirmPassword) ||
newPasswordIsInvalid($newPassword, $newConfirmPassword);
}
function removeEmptyFieldsFromArray($array) {
$returnArray = [];
foreach($array as $key => $value) {
if(!empty($value)) {
$returnArray[$key] = $value;
}
}
return $returnArray;
}
session_start();
$name = stripName($_POST['name']);
$surname = stripName($_POST['surname']);
$password = $_POST['password'];
$newPassword = $_POST['newPassword'];
$newConfirmPassword = $_POST['newConfirmPassword'];
if ($errorMessage = errorFound(
$name,
$surname,
$password,
$newPassword,
$newConfirmPassword
)) {
die($errorMessage);
} else {
$valuesThatNeedToBeUpdated = removeEmptyFieldsFromArray([
'name' => $name,
'surname' => $surname,
'password' => $newPassword
]);
// $valuesThatNeedToBeUpdated is an array that contains
// only the fields that aren't empty.
// Fields in this array are the ones that need to be updated
}
我认为John Slegers的回答非常好。这是程序应该如何工作的方式。
在我看来,它可以通过exceptions
实现得更"优雅"。使用 exceptions
的优点是,具有嵌套函数,您不必在每个级别中检查返回值并传递它 - 取而代之的是,您可以在一个点实现最终流,并且它是明确定义的。
想想花大约33美元买马丁的这本书 清洁代码.有一些好主意。你可能不同意所有这些,但它给了你一个很好的编程指南。
正如约翰在他的评论中指出的那样,尝试使用多个函数并给这些函数起非常好的名字。很高兴你不是 30 年前的程序员,你的函数和变量名称有 2 个字符......
您问这个问题是一个很好的迹象,因为您对自己的版本不"满意"。