GPA转换器从数字到字母的成绩在PHP


GPA converter from digits to letter grade in PHP

我已经制作了一个PHP代码,将从数据库中检索到的GPA转换为数字,如a,B,C等字母。等等,但所有的结果都是F,即使GPA是4.0。这是我的代码,请告诉我有什么问题

while($row = mysqli_fetch_array($show_result))
    {
    //$data holds the array
                $row['GPA'] = $grad;
             if ($grad <= 0.9 && $grad >=0.0)
             {
                 $grad = 'F';
             }
            else if ($grad<= 1.9 && $grad >=1.0 )
            {
                $grad = 'D';
            }
             else if ($grad <= 2.9 && $grad >=2.0)
            {
                $grad = 'C'; 
            }
             else if ($grad <= 3.9 && $grad >=3.0)
      {
          $grad = 'B';
      }
      else if ($grad == 4.0)
      {
          $grad = 'A';
      }
     echo "<td>" . $grad . "</td>";

$row['GPA'] = $grad;应为$grad=$row['GPA'];

我知道你没有要求代码审查,但我忍不住提出一些建议:

决定成绩的逻辑不必与数据库代码或html生成代码穿插在一起。此外,如果没有将截止值编织到逻辑中,它将更加灵活和可维护。也许像这样开始:

/**
* Get a letter grade from a numeric GPA and a grading scale
* $scale is an array of letter grades keyed by minimum GPA cutoffs,
* and should be sorted in descending order by key (cutoff)
*/
function get_letter_grade ($numeric_grade, $scale)
{
    $letter_grade = 'F';
    foreach ($scale as $cutoff => $grade)
    {
        if ($numeric_grade >= $cutoff)
        {
            $letter_grade = $grade;
            break;
        }
    }
    return $letter_grade;
}

然后你可以这样测试它(如果不使用单元测试框架):

$scale = array (
    4.0 => 'A',
    3.0 => 'B',
    2.0 => 'C',
    1.0 => 'D',
);
$test = 0.0;
while ($test <= 4.0)
{
    $grade = get_letter_grade ($test, $scale);
    echo "letter grade for $test is $grade'n";
    $test = round ($test + 0.1, 1);  // round to avoid floating point error
}